Skip to content

fix: BROS-483: User able to delete vector regions from View All mode #8647

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 24, 2025
Merged

fix: BROS-483: User able to delete vector regions from View All mode #8647

merged 5 commits into from
Oct 24, 2025

Conversation

@nick-skriabin
Copy link
Member

This PR addresses the issue when user is able to delete regions being in the View All mode.

@netlify
Copy link

netlify bot commented Oct 15, 2025 •
edited
Loading

✅ Deploy Preview for label-studio-docs-new-theme ready!

Name Link
🔨 Latest commit adfa6f8
🔍 Latest deploy log https://app.netlify.com/projects/label-studio-docs-new-theme/deploys/68fadfba5ed30b0008f0d5d7
😎 Deploy Preview https://deploy-preview-8647--label-studio-docs-new-theme.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Oct 15, 2025 •
edited
Loading

✅ Deploy Preview for heartex-docs ready!

Name Link
🔨 Latest commit adfa6f8
🔍 Latest deploy log https://app.netlify.com/projects/heartex-docs/deploys/68fadfba0e06e40008ebbe16
😎 Deploy Preview https://deploy-preview-8647--heartex-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions github-actions bot added the fix label Oct 15, 2025
@netlify
Copy link

netlify bot commented Oct 15, 2025 •
edited
Loading

✅ Deploy Preview for label-studio-storybook ready!

Name Link
🔨 Latest commit adfa6f8
🔍 Latest deploy log https://app.netlify.com/projects/label-studio-storybook/deploys/68fadfbaf8312f00079ebeb9
😎 Deploy Preview https://deploy-preview-8647--label-studio-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Oct 15, 2025 •
edited
Loading

✅ Deploy Preview for label-studio-playground ready!

Name Link
🔨 Latest commit adfa6f8
🔍 Latest deploy log https://app.netlify.com/projects/label-studio-playground/deploys/68fadfbaca2357000962976b
😎 Deploy Preview https://deploy-preview-8647--label-studio-playground.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@codecov
Copy link

codecov bot commented Oct 15, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 59.79%. Comparing base (1b188d7) to head (adfa6f8).
⚠️ Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
web/libs/editor/src/regions/VectorRegion.jsx 0.00% 1 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (1b188d7) and HEAD (adfa6f8). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (1b188d7) HEAD (adfa6f8)
pytests 1 0
Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #8647      +/-   ##
===========================================
- Coverage    66.92%   59.79%   -7.13%     
===========================================
  Files          792      554     -238     
  Lines        60661    39086   -21575     
  Branches     10346    10347       +1     
===========================================
- Hits         40597    23373   -17224     
+ Misses       20061    15710    -4351     
  Partials         3        3
Flag Coverage Δ
lsf-e2e 54.10% <0.00%> (-0.01%) ⬇️
lsf-integration 50.55% <0.00%> (-0.07%) ⬇️
lsf-unit 8.34% <0.00%> (+<0.01%) ⬆️
pytests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

hlomzik
hlomzik requested changes Oct 15, 2025
View reviewed changes
Copy link
Collaborator

@hlomzik hlomzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove console.logs

@nick-skriabin nick-skriabin requested a review from hlomzik October 20, 2025 12:57
@nick-skriabin
Copy link
Member Author

nick-skriabin commented Oct 24, 2025 •
edited by robot-ci-heartex
Loading

/git merge

Workflow run
Successfully merged: delete mode 100644 label_studio/io_storages/permissions.py

@robot-ci-heartex robot-ci-heartex merged commit cf8fe2c into develop Oct 24, 2025
44 of 46 checks passed
@robot-ci-heartex robot-ci-heartex deleted the fb-bros-483 branch October 24, 2025 03:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hlomzik hlomzik hlomzik approved these changes

Assignees

No one assigned

Labels

fix

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nick-skriabin @hlomzik @robot-ci-heartex